Really-Simple-Plugins / really-simple-ssl

Easily improve site security with WordPress Hardening, Two-Factor Authentication (2FA), Login Protection, Vulnerability Detection and SSL certificate generation.
https://really-simple-ssl.com
Other
144 stars 43 forks source link

dashboard is showing incorrect info #601

Closed rtpHarry closed 1 year ago

rtpHarry commented 1 year ago

Current view:

image

You can see top right 1 task, progress bar, 2 tasks.

I've noticed that after running the hardening, it doesn't clear out the "your wordpress version is visible" task. I manually X'd that just before this screenshot.

To see if the 2nd task was the 'upgrade' one, i also clicked X on the "database prefix is wp_", and it did a pulse on the progress bar, changed the % to 75, but didn't change the number of tasks.

Refreshing the page has fixed it now:

image
rlankhorst commented 1 year ago

Thanks for reporting it, we'll look into it 👍

rlankhorst commented 1 year ago

@rtpHarry I have just tried this on an empty sandbox. After enabling the plugin, then activating the recommended hardening features, I see the "wp version is visible" notice drop from the dashboard.

What happens during this process, is that when the "hide wp version" feature is enabled, the cached status is cleared. This triggers a new check, a curl request to the front-end, which checks if the wp version is still visible.

Do you maybe have a caching plugin active on your site? Thinking about this, it is quite possible that the curl check retrieves a cached page, with the wp version still in it.

Assuming you have some sort of caching enabled, I will do some tests to see if we can reproduce that. Maybe I can work around that by adding a random string as parameter to the homepage url, which should bypass caching in most situations.

This is implemented here: https://github.com/Really-Simple-Plugins/really-simple-ssl/tree/bypass-caching-on-wp-version-check

rtpHarry commented 1 year ago

Hmm yes, it is possible that I had already enabled LiteSpeed cache, I usually set up this and the cache as part of the launch / migrate process so I couldn't tell you from memory if that was the scenario.

I wasn't sure what was going on exactly with this originally, but I think that I might have reported two things in one issue.

I think that one issue is the wp version visible not cancelling itself (because of the cache, maybe)

And another issue is that the two tasks counts seem to get out of sync. I will pay attention next time I install this, to see if I can spot what is happening a little better.

rlankhorst commented 1 year ago

@rtpHarry In our upcoming release the tasks count, and open tasks are correctly updating based on selected options in the modal, so I'm closing this issue. Let me know if you are still experiencing this.