search

ReallySmallSoftware / cordova-plugin-firebase-crashlytics

Google Firebase Crashlytics Cordova plugin
Other
32 stars 80 forks source link

Remove empty spec version which breaks cordova-ios@5 #15

Closed piotr-cz closed 5 years ago

piotr-cz commented 5 years ago

Cordova-ios v5 introduced changes in plugin.xml parsing. Unfortunatelly it creates malformed Podfile when spec attribute is empty (spec="")

More info here: https://github.com/apache/cordova-ios/pull/577

Proposed Changes

Remove empty tag

ReallySmallSoftware commented 5 years ago

Thank you for this. I am going to check out ios 5 soon and make sure everything works.

piotr-cz commented 5 years ago

It's a bug in cordova-ios v5 but removing empty attribute doesn't hurt anything.