ReallySmallSoftware / cordova-plugin-firebase-crashlytics

Google Firebase Crashlytics Cordova plugin
Other
33 stars 80 forks source link

Update to latest depedendencies #18

Closed piotr-cz closed 5 years ago

piotr-cz commented 5 years ago

Proposed Changes

Updated

However it seems that org.json:json may be removed altogether as when building release I'm getting following error (however build finishes fine):

foobar\platforms\android\app\build.gradle:273: Error: json defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]
    implementation "org.json:json:20171018"
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "DuplicatePlatformClasses":
   There are a number of libraries that duplicate not just functionality of
   the Android platform but using the exact same class names as the ones
   provided in Android -- for example the apache http classes. This can lead
   to unexpected crashes.

   To solve this, you need to either find a newer version of the library which
   no longer has this problem, or to repackage the library (and all of its
   dependencies) using something like the jarjar tool, or finally, rewriting
   the code to use different APIs (for example, for http code, consider using
   HttpUrlConnection or a library like okhttp).
ReallySmallSoftware commented 5 years ago

Thanks. I will merge this manually as the iOS dependencies have changed with the update to cordova-ios 5.

piotr-cz commented 5 years ago

If you are thinking about #15 there it should not affect this PR

piotr-cz commented 5 years ago

Note: Resolved in afb5a105bb

piotr-cz commented 5 years ago

Error didn't go away after afb5a105bb