search

ReallySmallSoftware / cordova-plugin-firebase-crashlytics

Google Firebase Crashlytics Cordova plugin
Other
32 stars 80 forks source link

Scripts have been removed but are referenced as hook #43

Open marcjulian opened 3 years ago

marcjulian commented 3 years ago

Expected Behavior

Scripts are available for the hooks

  <hook type="after_plugin_install" src="scripts/after_plugin_add.js" />
  <hook type="after_platform_add" src="scripts/after_plugin_add.js" />
  <hook type="before_plugin_uninstall" src="scripts/before_plugin_rm.js" />

Actual Behavior

Scripts have been removed in 566833f4f2a091b3fbee3d9d85540c337bd4f418 now the hooks are failing because of the missing scripts.

Steps to Reproduce the Problem

Specifications

nikunjkakadiya3008 commented 3 years ago

Having the same issue. Please review PR ASAP

davidquon commented 3 years ago

Was about to open the same issue. Nice find @marcjulian. 👏

davidquon commented 3 years ago

This actually breaks Ionic AppFlow CI which I filed an issue for. https://github.com/ionic-team/ionic-framework/issues/22284

Jason-Lindley commented 3 years ago

Same issue here. Anything we can do to get this PR merged?