search

ReallySmallSoftware / cordova-plugin-firestore

A Google Firebase Firestore plugin to enable realtime synchronisation between app and cloud and automatically handle limited connectivity.
Other
22 stars 10 forks source link

Updated name of Firestore pod. #2

Open jhohmanem opened 6 years ago

jhohmanem commented 6 years ago

I was attempting to use your plugin and everything worked well in Android. I attempted to build for iOS and I was getting a message in Xcode that the Firestore library was not found. It looks like the pod that was being requested was incorrect. I don't know if it has been renamed or something, but this name and using the most current version worked for me.

ReallySmallSoftware commented 6 years ago

Thanks for this fix - I meant to acknowledge this before. Will be merging it back in. :-)

wrasmuss-eng commented 6 years ago

@ReallySmallSoftware We (Engage Mobile) have since added other changes to this branch (master) of our fork. These changes were to allow more flexible firebase configuration/connection.

Also, we are not sure if the original change was exactly what was needed or not.

Finally, we are trying to figure out the best way to support other Firebase functionality (storage, analytics, etc.) in the same app. We think there are some conflicts between the Firebase level configuration when we try to use other plugins. We may make some changes for this purpose too.

Thoughts?

ReallySmallSoftware commented 6 years ago

@wrasmuss-eng Hi, I've sort of been keeping track of your changes - I am planning to try and include the flexible configuration as I like this, and in due course will probably follow the same pattern in my other Firebase plugins if it works OK. I duplicated your original change and tested it on iOS and it seemed to work fine for me.

As far as the other functionality, I have encountered conflicts with other Firebase plugins previously. I have found with some plugins the pace of change with the Firebase libraries is so great there can easily be things that are out of date. I had a previous request to implement storage and my personal view was a modular approach with a plugin for each piece of Firebase functionality. I think some Firebase plugins have tried to implement multiple features in a single plugin.

I think your flexible configuration approach is a more grown up and complete approach rather than just relying on the default application but I would expect that all Firebase plugins in a single app would need to support it.

I'm not sure if these are the kind of thoughts you were after! Please feel free to knock any ideas back and forwards if you think it would help.

wrasmuss-eng commented 5 years ago

@ReallySmallSoftware We decided to permanently fork this repo. We put it in a new github project called: engage-firebase-cordova. As the name implies we're focussed more an total firebase plugin that meets the needs of the kind of apps we develop. We will leave our repo that is a fork of this one up for another week or so if you would like to review/merge any of the other changes we've made.

We put a note about the nice work you did here in the readme.md for the new project. Please let us know if you would like any edits to that note. Thanks for the great work! Let us know if we can help out with this project in the future.

ReallySmallSoftware commented 5 years ago

@wrasmuss-eng Thanks for letting me know. I believe I have merged in your latest changes and I will keep an interested eye on your new repo.

Thanks for your kind words and I wish you all the best. The firebase stuff was the first I had contributed back to the OS community so I am gratified that someone has found it of use.