search

ReallySmallSoftware / cordova-plugin-firestore

A Google Firebase Firestore plugin to enable realtime synchronisation between app and cloud and automatically handle limited connectivity.
Other
22 stars 10 forks source link

Fix: clean up file structure & initialize option bug, etc... #6

Closed wf9a5m75 closed 5 years ago

wf9a5m75 commented 5 years ago

Proposed Changes

Thank you for creating this plugin. This is the developer of cordova-plugin-googlemaps. I thought I would create the same plugin by myself, but you already created for three platforms. You save the time of mine and many developers!

However I could not build this plugin with provided demo code. That's why I fixed it. Also, I prefer class name based files instead of super large JS file. Actually it was the road of I experienced before.

I would like to help you to improve this plugin. Do you have TODO list?

wf9a5m75 commented 5 years ago

@ReallySmallSoftware ping

ReallySmallSoftware commented 5 years ago

Sorry - I thought I replied to you by email. I am grateful for your changes - I just need to review them and would like to take you up on your offer. My only conditions are:

1) Any new functionality must work across all three platforms 2) No breaking changes if at all possible 3) Where possible the API must match the web API published by Google

I see nothing you have done or suggested to make me think any of the above will be a problem. :-)

wf9a5m75 commented 5 years ago

Thank you for merging. I agree your points. My goal is to provide the common API for three platforms that is the same as the Google's one. So I won't break three points ;)

And thank you for accepting the collaborate offer. I will mainly develop on my forked repo, then send it as PR to here. After that, I will merge to this repo. This can keep clean on this repo.

I will also create @ionic-native/firestore plugin which is typescript wrapper plugin for this plugin. It would be useful for other typescript users. (Don't worry, that's my work) The benefit of the wrapper plugin leads lots of users.

Let's improve this fancy plugin together!