search

ReallySmallSoftware / cordova-plugin-firestore

A Google Firebase Firestore plugin to enable realtime synchronisation between app and cloud and automatically handle limited connectivity.
Other
22 stars 10 forks source link

Use own package name instead of direct class #7

Open wf9a5m75 opened 5 years ago

wf9a5m75 commented 5 years ago

Current Behavior

This plugin currently makes Firestore under the window property directly.

    <js-module src="www/firestore.js" name="Firestore">
      <clobbers target="Firestore"/>
    </js-module>

There is a possibility to conflict with other plugins.

Expected Behavior

One suggestion is to create own package name. For example, my plugin creates plugin.google.maps in order to prevent conflicting with others.

You know what even Google makes own package name firebase.firestore.Firestore.

Would you like to create your plugin move to plugin.firebase.firestore.Firestore? ( If you use plugin.firesbase.firestore, developers can understand to just add plugin. )

ReallySmallSoftware commented 5 years ago

This does seem like a good idea.

wf9a5m75 commented 5 years ago

I have been developing own library for firebase realtime database these days. I will come back for this library in two weeks.

I aware current JS API implementation of this library has several problems to archive the plugin.firebase.firestore.Firestore. Actually recreating a new library from scratch is faster than modifying this library.

I will invite you to my current work project in couple of days :) Just a moment please.