Realm667 / WolfenDoom

"WolfenDoom - Blade of Agony" | Important: This is only meant for development and testing purposes. You are NOT ALLOWED to use material from this repository for your own projects. Important: This repository is for development and testing purposes, you are NOT ALLOWED to use the copyrighted material for your own projects without our permission!
http://boa.realm667.com
259 stars 26 forks source link

[Delta Touch] Attempting to use the Kar98k scope insta-crashes the game. #1204

Closed Shockwave508 closed 7 months ago

Shockwave508 commented 2 years ago

As of commit 8d6c48c, attempting to use the Kar98K's scope in any way will insta-crash the game. Will there be a CVAR or some other option to revert to the shaderless zoom on a per-player basis?

GZDoom version: v4.7.1 Delta Touch version: v4.6 (user and post shaders disabled)

AFADoomer commented 2 years ago

Oh, God damn it. Fucking Delta Touch.

AFADoomer commented 2 years ago

Reverted the commit.

Tormentor667 commented 2 years ago

Any chance of letting delta touch update to make this feature work?

AFADoomer commented 2 years ago

There's literally nothing here that didn't work in GZDoom over a year ago. I have no idea why it doesn't work.

Shockwave508 commented 2 years ago

@Tormentor667 Delta Touch v4.6 is the latest version.

Delta has always been known to be generally-incompatible with shaders designed for desktops. I do recall that a workaround fix for the projector screen in INTERMAP was implemented. Perhaps something similar can be arranged for the Kar98K scope, as a CVAR, so everyone can still play the game.

Tormentor667 commented 2 years ago

That would be cool if we find a workaround - afaik, @Talon1024 took care of that. Generally, I'd like to avoid removing improvements to keep compatibility with Delta Touch for all sakes. Is there a chance that DT catches up with the features instead?

Talon1024 commented 2 years ago

That workaround was a1556dd5a5b3b4798784fcc35b8123d6d8641ebf, and it involved opening the shader in GLSLViewer and taking a bunch of screenshots.

It may not be possible to make the advanced Kar98k scope work properly in the GLES renderer or Delta Touch, because it's not a simple animation like the old video shader. IIRC the new Kar98k scope effect uses camera textures and makes the scope look stretched near the edges of the circle, and that's impossible to emulate using an animated texture.

AFADoomer commented 2 years ago

It doesn't even do that (though I had planned to add something similar). All the shader was doing was making the camera texture fullbright so that the image isn't affected by brightness of the player sector.

This particular implementation uses a model to overlay the scope image and the camera image and allow both to be smoothly scaled/zoomed easily. Delta Touch probably doesn't like the camera texture being used as a model skin.

Talon1024 commented 2 years ago

All the shader was doing was making the camera texture fullbright so that the image isn't affected by brightness of the player sector.

In that case, a BRIGHT label on the scoped Kar98k states or a brightmap should be sufficient.

AFADoomer commented 2 years ago

Brightmaps don't seem to properly apply to a camera texture - at least not when they are used as a model skin. And BRIGHT makes the entirety of the scope overlay bright, not just the camera image.

I'll try to rework this to use a shape canvas instead of the model, I guess...

Tormentor667 commented 2 years ago

Is this issue still relevant?

DungeonMaster555 commented 2 years ago

test version of Delta touch 4.7 with the most stable version of gzdoom 4.8.2 https://drive.google.com/file/d/1Rl6PvHgTwmkSVoUo8F1O-nCSTDUUBeOs/view?usp=sharing

Tormentor667 commented 2 years ago

Тестовая версия Delta touch 4.7 с самой стабильной версией gzdoom 4.8.2 https://drive.google.com/file/d/1Rl6PvHgTwmkSVoUo8F1O-nCSTDUUBeOs/view?usp=sharing

English please

DoomJedi commented 2 years ago

Test version of Delta touch 4.7 with the most stable version of gzdoom 4.8.2 (google translate) Much faster than to demand english and wait for a day or 2 - takes half a minute.

Tormentor667 commented 2 years ago

I think it's not my job to translate people who are not interested in giving the effort to write in a more common international language than russion. I mean, schreibe ich deutsch die ganze Zeit?