search

Realm667 / WolfenDoom

"WolfenDoom - Blade of Agony" | Important: This is only meant for development and testing purposes. You are NOT ALLOWED to use material from this repository for your own projects. Important: This repository is for development and testing purposes, you are NOT ALLOWED to use the copyrighted material for your own projects without our permission!
http://boa.realm667.com
255 stars 26 forks source link

No skybox rendered in either C3M3_A or C3M3_B #1425

Closed hawkwind3 closed 3 months ago

hawkwind3 commented 3 months ago

As described on the tin. Just F_SKY1 is rendered. This one goes back to at least GZDoom 4.10. Screenies attached. The good one, bottom, is from BOA 3.1.

no skybox c3m3a and b

good skybox boa 3 1

x3003 commented 3 months ago

Yes, it now looks like day, instead of night.

Edit: it got broken somewhere between mid feb and mid apr. Edit2: the problem probably comes from: https://github.com/Realm667/WolfenDoom/commit/9837b8254d493b690eb5665b9d13c07b240c75da

hawkwind3 commented 3 months ago

Could be.

AFADoomer commented 3 months ago

Yes, because I'm sure the change in the engine that necessitated that fix has nothing to do with this... 🙄

hawkwind3 commented 3 months ago

So what to do ? Can it be fixed ? Just looks odd seeing searchlights in daytime.

x3003 commented 3 months ago

I uncommented the old code and removed the new code in skyboxview and ran an older version of gzdoom. It is the fix that makes the sky not rendered. Seems there's a catch 22 now.

AFADoomer commented 3 months ago

Of course the old code works in an old version of GZDoom. A change that was made in the engine is what broke things in the first place.

My hacky fix apparently doesn't fully restore the original behavior.

I currently have zero motivation to deal with any of this.

x3003 commented 3 months ago

My hacky fix apparently doesn't fully restore the original behavior.

No, but my point is that in order to fix a little bug that was there (in gzdoom) for many [?] years and most didn't care about, there's now a situation that possibly breaks a lot of wads. And yours is one of them, unfortunately.

hawkwind3 commented 3 months ago

Fixed.