Realm667 / WolfenDoom

"WolfenDoom - Blade of Agony" | Important: This is only meant for development and testing purposes. You are NOT ALLOWED to use material from this repository for your own projects. Important: This repository is for development and testing purposes, you are NOT ALLOWED to use the copyrighted material for your own projects without our permission!
http://boa.realm667.com
259 stars 26 forks source link

C3M0_A - displaying (video?) problems... #465

Closed MuadDib90 closed 3 years ago

MuadDib90 commented 3 years ago

I once have this problem, but I don't remember, if it was resolved anymore.

In this mission this strange behavior was happening. When pointing in some certain directions (I couldn't figure out when exactly this was happening) display starts to brighten with someting I can't even name... When not moving, it will cover all your display (as seen in second picture), leaving the game impossible to play. The worst place, where this was happening (nearly) wherever you pointed, was Erik's room. I though I won't be able to go through that room. (Was, with the help of automap...)

004 005

AFADoomer commented 3 years ago

Can you recreate this and then try to disable the post-processing shaders one at a time to narrow down which one is the problem?

Tormentor667 commented 3 years ago

It seems as if the crosshair and the bloom effect somehow are interfering, or the lense flares... but that would be my first guess.

MuadDib90 commented 3 years ago

From what I have just found out, when I disable all three shaders (motion blur, vignette, lens flares) the effect disappears. Also the crosshair moves smoothly through places, where it was appearing.

On the other hand, I guess it is not doing only one of them, because if I turn each one of them on (individually ), it is doing something. Vignette will blacken your screen, lens flares are doing something similar as above but not in that scale, and motion blur is stopping the screen on that spot (when you move the screen freezes for some time, then unfreeze again, when you are "out of that focus point"). And together they are unbearable nuisance...

(It is doing not only when you're looking into the lights. Also when you're walking and "staring" into the wall for example...)

AFADoomer commented 3 years ago

Thanks for the testing and confirmation... I imagine that this is going to be similar to my own bug with the color temperature shader in OpenGL, where it is hardware dependent. Are you using the Vulkan renderer or OpenGL?

You've captured my thoughts on all of these "always on" overlay effects in general as well 😉 .

MuadDib90 commented 3 years ago

No problem. Using OpenGL. I've heard that Vulkan is in the state of development, so I do not want to put myself into more trouble than necessary. :D

AFADoomer commented 3 years ago

I think it is past the "in development" phase at this point.

The reason that I ask is that my bug only happens with the OpenGL renderer, and not with Vulkan. Can you test that with your machine?

MuadDib90 commented 3 years ago

Ah, didn't know that.

Tested. With Vulkan it is about 95 % better. It is still doing something, but only when I look into lights, as it seems (it is small and not developing into the whole screen)

Username-N00b-is-not-available commented 3 years ago

Possibly connected with my dated report in https://github.com/Realm667/WolfenDoom/issues/384#issue-811375079 (search for 'nuclear explosion'). That one occured to me in SM03.

Tormentor667 commented 3 years ago

I wonder, should we make Vulkan the default for the standalone or OpenGL?

AFADoomer commented 3 years ago

If we set vid_preferbackend to 1, it will use Vulkan if available, and fall back to OpenGL if not.

I doubt BoA will running on SoftPoly (vid_preferbackend = 2).

Tormentor667 commented 3 years ago

Then let’s go for that :)

Ozymandias81 commented 3 years ago

The fact is that setting if for Vulkan might cause several slowdowns for players, specially if they have an Intel based rig with nVidia gpu. I get worse performance with my AMD based pc (Fx 6300 6core 3.5ghz), where my gpu is an Nvidia GeForce GT 1030 2gb. Seen instead on some people who had RX 560 a good step up in terms of performance under Vulkan, while instead have crazy slowdowns with OpenGL.

Gonna do a pair of tests with latest devbuild... BTW we SHOULDN'T base our April release over a devbuild, we already got issues during C2 release. Anyway time for tests.

Ozymandias81 commented 3 years ago

Well, the Pixelated Film Grain seems to slowdown performance greatly on screen, with both Vulkan/OpenGL solutions. I do get a better framerate on TITLEMAP under Vulkan running the game from official "setup" (so custom executable, everything default): 143fps Vulkan, 115 OpenGL. On C3M0_A, using the map command, I do see a critical slowdown simply when starting the map: spikes of continuos slowdown from 4fps to 12fps, with all PP shaders on, but I get 25-35 as intended quite stable with all PP shaders on beside Pixelated Film Grain (this under Vulkan). I bet it gets worse with OpenGL.

EDIT: Nevermind, once I was here typing, I then got back back to the game and it was running slow again... Until I opened the menu and closed it (it was on menu before switching windows). Anyway I don't get any visual issues with 4.6 r195 actually, this with any kind of PP shaders on screen. My gpu has drivers updated to most recent ones (GT1030 2gb). So related to some junk from zscriptified stuff? Since now even with Pixelated Film Grain I have stable framerate...

RE_EDIT: Indeed with OpenGL I lose 10 fps here: 17 vs 29, all PP shaders on

Screenshot_BoA_20210406_181227 Screenshot_BoA_20210406_181403

Tormentor667 commented 3 years ago

Tried it on my pc with C3M6_A and wow: The Vulkan renderer is indeed much faster. I got an FPS gain of 200% on that map, from 20FPS to 60FPS. I guess we definitely must set Vulkan to default :)

Ozymandias81 commented 3 years ago

It's mildly true yes, even I gained 30 on Opengl to 50 on Vulkan, but always on Vulkan I got these terrible spikes again, and they are very random it seems. It was running good until I started to rotate around myself for a while to see if performance was stable... and then I got this. Screenshot_BoA_20210406_183232

Username-N00b-is-not-available commented 3 years ago

@MuadDib90, does the issue from your original post still happen? I had experienced something similar on a Commander Keen level, but that was quite a long time ago. It does not occur for me now.

MuadDib90 commented 3 years ago

@Username-N00b-is-not-available yes, I saw your video.

Newest version of gzdoom, up to date repository. Tried to turn everything on. Tried it again on C3M0_A. Short answer: yes.

OpenGL causes it still more than Vulkan. But it is noticeably lower than before. So I would consider it "tweaked down" as much as you could at this point. Thank you.

We can consider it done by now, from my point. :)

Username-N00b-is-not-available commented 3 years ago

@MuadDib90 Could you post a video from your machine, please? In what locations does it occur now? Is it still the Erik room, as in your first post? I also tried to reproduce this problem there, but, once again, it does not occur to me anymore for some reason...

MuadDib90 commented 3 years ago

@Username-N00b-is-not-available Man, this is so frustrating...

I recorded a video about OpenGL, where I could not shown it properly (to my surprise), there are only those parts, where screen "stops" and "blur" as when you went through walls using NOCLIP in vanilla Doom. But I swear I do not making it up, those "things" from the first post at the top were there, but not so much anymore, and also with no such strength to make the game impossible to play.

OpenGL.zip (too long to upload directly)

Then the OBS studio software gave out and I was not able to record a video with it; only sound. So I tried with Bandicam, but that caused jerky video (tried to cover the same place with Vulkan this time). Despite that it shows lesser problems with this issue.

https://user-images.githubusercontent.com/73436978/115601356-fb265e80-a2dd-11eb-8bd2-8c79b98473e0.mp4

AFADoomer commented 3 years ago

Can this be considered a hardware-specific issue and closed?

Some player may just need to disable the post-processing options if their machines do not handle them well.

Tormentor667 commented 3 years ago

Yes, I agree. We could prepare an explanation in the FAQ on the website for this. I will take care later.

Tormentor667 commented 3 years ago

2021-04-29_084802

Did it. @Talon1024 if there is anything I can improve language-wise, let me know.