search

Realm667 / WolfenDoom

"WolfenDoom - Blade of Agony" | Important: This is only meant for development and testing purposes. You are NOT ALLOWED to use material from this repository for your own projects. Important: This repository is for development and testing purposes, you are NOT ALLOWED to use the copyrighted material for your own projects without our permission!
http://boa.realm667.com
257 stars 26 forks source link

Room should be darker #508

Closed x3003 closed 3 years ago

x3003 commented 3 years ago

In a room in c1m2, when you turn off all the little lights, the room becomes brighter, not darker...

Screenshot_Doom_20210423_165109

Username-N00b-is-not-available commented 3 years ago

@x3003 The table lamps are turned off when you first visit the area, so you turned them on ;-) It seems that your screenshot has an increased gamma, which could have tricked you into thinking that the lights are already on. With gamma 1, the room is almost pitch-black (but it becomes quite okay when you switch on all the table lights).

x3003 commented 3 years ago

In here I can light the room w/ this monitor, so I dimmed it to 50 %, so I needed to add some gamma while playing else I won't see a damn thing ;)

Username-N00b-is-not-available commented 3 years ago

Yeah, BoA has quite a lot of really dark areas. I also have brightness reduced (but on a laptop screen, not a monitor), though thankfully even with 20% brightness (which I am using right now) gamma 1.3 or 1.4 usually seems to help.

Ozymandias81 commented 3 years ago

I tested it a day ago and everything was fine. Since I worked on those personally, I am sure that the place work as intended. Check this. (wait)

EDIT: you are right, recent culling changes have broken somehow actor behavior, since there are additional lights in place which are turned on/off via scripts, and this is how they look off @AFADoomer (they looks on) Screenshot_Doom_20210423_182137

Ozymandias81 commented 3 years ago

Lights there have been always with big radius I have to say, what I did during the common scripts porting (mirrors, lights etc) was this: applied tag to target external lights and applied then script call to tablelights, and this is present (without those bigger lights btw) quite everywhere on maps. It has been necessary to fix external pointlights that were applied over switchable actors, were before my changes they were just not changing during on/off. Now the thing is inversed, as dormant the TableLight is on with target pointlight off, and as soon as you turn one of them on, the object turns off and then pointlight is set on

image Screenshot_Doom_20210423_195852 Screenshot_Doom_20210423_195859

AFADoomer commented 3 years ago

Should be working properly now.

You were correct, this was related to the culling addition... The DORMANT flag is already toggled when the various culling base actors are activated/deactivated, so the toggling of the flag in the light actors that used to be necessary is now redundant. It was effectively setting the DORMANT flag's value back, causing the lights to enter the opposite to correct state.

Ozymandias81 commented 3 years ago

Thank you very much @AFADoomer :)