search

RealmeIP / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

PART1ONLY option in release.sh doesn't work properly #332

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The goal of PART1ONLY option in the release script 
(dev-utils/scripts/release.{sh,bat}) is to generate a subset of the OpenJPEG 
binaries AND sources (with only the openjp2 library, and the opj_compress, 
opj_decompress, and opj_dump executables).

Currently it only creates a subset for the binaries but include all the sources 
in the tar.gz archive.

Original issue reported on code.google.com by antonin on 3 Apr 2014 at 9:00

GoogleCodeExporter commented 8 years ago 
Just for reference. It will be very hard to extract only Part-1 from the 
OpenJPEG source code, since src/lib/openjp2 contains pointers and reference to 
JPIP, MJ2 and JPWL implementation.

It is difficult to automate. The conclusion was that this is a one -time job, 
which can be done by hand, when commitee review OpenJPEG code.

Original comment by mathieu.malaterre on 28 Apr 2014 at 7:49

GoogleCodeExporter commented 8 years ago

Original comment by mathieu.malaterre on 28 Apr 2014 at 7:49

GoogleCodeExporter commented 8 years ago 
@mathieu,

if code in src/lib/openjp2 contains proper defines (I think it does), then a 
utility like coan (http://coan2.sourceforge.net) can be used to preprocess the 
source ode automatically.

Original comment by m.darb...@gmail.com on 22 Nov 2014 at 12:10

GoogleCodeExporter commented 8 years ago 
@antonin do you think you'll need that in the future ?
@matthieu I have not checked but I think we had to move JPIP-only function 
within libopenjp2, I do not believe they were #igdef guarded...

Original comment by mathieu.malaterre on 24 Nov 2014 at 8:01

GoogleCodeExporter commented 8 years ago 
@mathieu No we'll not need this in the future so it can actually be removed 
from CMake options.

Original comment by antonin on 24 Nov 2014 at 12:22

GoogleCodeExporter commented 8 years ago 
I did not remove the option as it might be useful to build only PART1 related 
components but I close the issue because there is no need anymore to also 
package a subset of the source files.

Original comment by antonin on 15 Jan 2015 at 5:11