search

RealyUniqueName / JStack

Friendly stack traces for Haxe/JS and Haxe/PHP. Makes haxe.CallStack point to haxe sources.
MIT License
31 stars 2 forks source link

Update CallStack.hx #11

Closed wiggin77 closed 7 years ago

wiggin77 commented 7 years ago

Include nodejs as supported target, and fix compile error for other targets using CallStack.toString(stack)

RealyUniqueName commented 7 years ago

How can i get nodejs define while js is not defined?

Gama11 commented 7 years ago

Maybe this patch is needed? https://github.com/HaxeFoundation/hxnodejs/pull/94

wiggin77 commented 7 years ago

I agree it is strange, but I hit the compile error in a nodejs project. At some point in the compilation process js is not defined but nodejs is -- probably during macro execution.

After reviewing the issue Gama11 referenced, my PR may not be the best way to fix this (except the toString does need an arg). I'll grab the hxnodejs patch and try again.

wiggin77 commented 7 years ago

Hmmm. I already have the latest hxnodejs which includes that patch.

wiggin77 commented 7 years ago

I'll close this, and provide PR for just the toString issue.