search

RebelTechnology / OwlServer

Web-based Client/Server application for the Open Ware Laboratory
GNU General Public License v2.0
2 stars 2 forks source link

Create new patch page: unable to add source file from GitHub #195

Closed sam-artuso closed 7 years ago

sam-artuso commented 7 years ago

How to reproduce:

  1. Go to "My patches"
  2. Click "Create patch"
  3. Paste this URL in the "GitHub File Url" input box: https://github.com/pingdynasty/OwlPatches/blob/master/FreeVerbPatch.hpp
  4. Click "Save"
  5. A new patch without a source file is created.

I believe this is a bug with the frontend because the URL of the source file is not sent along with the payload of the POST /patches API call:

image

Sorry if this was already known or if for some reason is not an issue.

goozo commented 7 years ago

it works for me on staging, did you click the add button after pasting the github url? ( I noticed it wasn't in your steps to reproduce ) otherwise which browser and version can you reproduce this in?