search

RebelTechnology / OwlServer

Web-based Client/Server application for the Open Ware Laboratory
GNU General Public License v2.0
2 stars 2 forks source link

Add support for uploading patch resources #261

Open pingdynasty opened 2 years ago

pingdynasty commented 2 years ago

We should support adding resources to a patch, such as samples and wavetables.

The easiest way to achieve this will be to simply add support for '.wav' source files, and make sure they are not visualised as text. Instead there should be a 'Store' button that sends and saves the resource to a connected OWL. (with confirmation: This will overwrite any existing resource with the name XYZ.wav)

antisvin commented 2 years ago

We should probably reserve some extension like .bin or .dat for uploading LUTs or anything else that is not stored in WAV format

pingdynasty commented 2 years ago

And/or allow the patch author to mark an uploaded file as a resource.

Meanwhile .wav feels like a useful, safe (are there many wav viruses out there?) step forward which doesn't require storing more metadata. Maybe adding .dat is also safe - and useful?

antisvin commented 2 years ago

Marking a file as resource and supporting a specific extension for non-WAV resources achieve the same thing, I don't think we need both. I've suggested choosing a generic extension simply because it seems like it would take less work.

For .dat files we will only store data as is (no metadata to parse, can't preview them, etc), so it certainly can't be less safe than storing WAVs