search

RebelTechnology / OwlServer

Web-based Client/Server application for the Open Ware Laboratory
GNU General Public License v2.0
2 stars 2 forks source link

Updating a patch parameter ID wrongly updates the IDs of other parameters #317

Open notno opened 3 months ago

notno commented 3 months ago

Something is broken in the details page.

I'm trying and failing to get the site running locally, but if I can I'll be happy to try to fix.

pingdynasty commented 3 months ago

Hi Nathan, thanks for the report. How can I reproduce? Note that the parameters are automatically sorted by id, so changing one id might reshuffle them in an unexpected way. Perhaps it would be better to sort them on save only.

Martin

Enviado de Samsung Mobile

-------- Mensaje original -------- De: Nathan Rosquist @.> Fecha: 31/5/24 12:33 (GMT+01:00) Para: RebelTechnology/OwlServer @.> Cc: Subscribed @.***> Asunto: [RebelTechnology/OwlServer] Updating a patch parameter ID wrongly updates the IDs of other parameters (Issue #317)

Something is broken in the details page.

I'm trying and failing to get the site running locally, but if I can I'll be happy to try to fix.

— Reply to this email directly, view it on GitHub https://github.com/RebelTechnology/OwlServer/issues/317 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6NJXLBASS6ZGCBZ5ACUTZFBGYBAVCNFSM6AAAAABISR4LSGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDONJQHEYTCNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

notno commented 3 months ago

Hi Martin, thanks for your response. Here are the steps to reproduce:

  1. Click create patch
  2. Name and save patch
  3. Click "edit patch" pencil icon
  4. Click "add parameter". A new PARAMETER_A shows up, sorted to beginning of list.
  5. Change the first PARAMETER_A to be PARAMETER_H
  6. Notice that there are no PARAMETER_A's and there are two PARAMETER_H's
  7. Change either of the H parameter back to A and both H's become A's again

Bonus 1:

  1. From here change parameter B to param A and back to B
  2. Notice that there are now 3 parameter Bs

Bonus 2:

  1. Attempt to make 5 more buttons and turn two of them into outputs and have them all have unique IDs.
  2. Notice that changing one into an output turns them all into outputs.

I hope this is clear. I'd be happy to send a screencast if you can't reproduce.

Right now I'm working with gen on windows, and have been able to create cpp code from gen, send the cpp and header files to my linux machine, and then compile with custom metadata.h and load on my Witch with OwlProgram. This is annoying but fine for me personally, but it makes sharing working patches on the website impossible. It's such a good resource already, it would be a shame to have this one aspect not work.

I'm on Chrome on linux, but have tried other browsers and on Windows too.