RebelTechnology / OwlServer

Web-based Client/Server application for the Open Ware Laboratory
GNU General Public License v2.0
2 stars 2 forks source link

Recommended Patch #71

Open pingdynasty opened 9 years ago

pingdynasty commented 9 years ago

Logged in users should be able to recommend a patch. Clicking Recommend on a patch (star icon) brings up a dialogue where the user enters what the patch is recommended for: I recommend FooPatch for: ... On the patch page, the most recent recommendations should be listed with a total count. The patch library should implement a new search order: Recommended (star icon). The Popular Patches search order (#151) should use Recommendations.

goozo commented 7 years ago

just thinking a couple of things on this one, I'm thinking when a user recommends a patch we'll probably want to keep a record of the user who recommended it so that said user could in theory de-recommend later and also to prevent multiple recommends for the same item from the same user. Also I guess it could open up the opportunity to later have a notification system so when someone logs in they would see who had 'recommended' their patches, similar to a 'like' notification. So I'm kind of thinking about saving who recommended plus a timestamp, what do you think?

Also below a possible UI, the star would become orange and filled when the button is clicked. image

image

goozo commented 7 years ago

I wasn't sure if we wanted to have the word 'recommend' in there to make it obvious what the star is for. Unfortunately the word recommend is kind of long :-) I see why github went with "star" :-)

I guess another thought is, from where in the app do we want users to be able to 'recommend' ? The example above is in the patch list view, but we could also only have the option to recommend from the patch details... (or both which I had initially thought of)

pingdynasty commented 7 years ago

+1 for keeping record of who has recommended what, when.

pingdynasty commented 7 years ago

To my mind the 'star' action would come when you've tried out a patch, so on the Patch Details page.

The way Github works is nice. If you view a project e.g. https://github.com/partkeepr/PartKeepr you have a button to star/destar, and you can see how many stars the project has. If you go to a list, e.g. https://github.com/partkeepr you can again see how many stars, but there's no button to star it. Clicking on the number in either case shows who has starred it.

We can use github as a model, starting with a simple 'star this project' button on the patch details page. Go ahead and put the word Star in, or Recommend if you think it fits, or even just a tooltip (I understand tooltips don't work on mobile...)

goozo commented 7 years ago

possible popularity weighting for sorting patches by 'popularity':

pingdynasty commented 7 years ago

It looks a bit sad with '0 Stars'. Can we change it to just 'Star', if there are none? (or 'Star this patch', though I think that's a bit long)

goozo commented 6 years ago

0 removed in next release