fix: null error if no rootIsolator on the context

Rebelizer / pellet

Isomorphic framework using react, nodejs, and love

http://pellet.io

MIT License

91 stars 9 forks source link

fix: null error if no rootIsolator on the context #13

Closed vevo-elyse-gordon closed 9 years ago

vevo-elyse-gordon commented 9 years ago

When calling unmountComponentAtNode directly to support using Pixastic, this was throwing an error because there was no rootIsolator. Not sure why it doesn't have a this._owner and does not have a rootIsolator, but this null check fixes the issue.

ghost commented 9 years ago

lets talk about this tomorrow in the office. I would like to understand why your code is destroying the context and your losing rootIsolator. This could be the real problem to fix and I am not sure if we should air bag the exception. This could lead to memory leaks etc.