search

Rebilly / Rebilly-NET-SDK

.net SDK for Rebilly.
MIT License
1 stars 0 forks source link

Generate Signature #1

Open adamaltman opened 8 years ago

adamaltman commented 8 years ago

Rebilly.js uses a signature created as shown in PHP. We need an equivalent for .NET too:

https://github.com/Rebilly/rebilly-php/blob/9ee460361827aa938999c1acab30b42d3774709a/src/Util/RebillySignature.php#L44

rmcfadden commented 8 years ago

Willdo!

On Fri, Jul 29, 2016 at 5:16 AM, Adam Altman notifications@github.com wrote:

Rebilly.js uses a signature created as shown in PHP. We need an equivalent for .NET too:

https://github.com/Rebilly/rebilly-php/blob/9ee460361827aa938999c1acab30b42d3774709a/src/Util/RebillySignature.php#L44

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq6bjZlMiigtp7bxz_GsOMJoZWJZUks5qae8OgaJpZM4JYIwv .

adamaltman commented 8 years ago

Thanks, here is a reference from the older implementation. https://github.com/Rebilly/rebilly-dotnet-client/blob/master/Library/Rebilly/RebillySignature.cs

rmcfadden commented 8 years ago

Gotcha. Thanks. The SDK is coming along nicely and it has good test code coverage. I haven't worked on it much in the last couple of weeks; however, the plan is to work on it for 1-2 hours a day for the next two weeks, at which time I should 90+% of the entities mapped.

How's your team going with the new rules engine?

Enjoy your weekend and I'll talk to you soon,

Ryan

On Fri, Jul 29, 2016 at 8:39 AM, Adam Altman notifications@github.com wrote:

Thanks, here is a reference from the older implementation. https://github.com/Rebilly/rebilly-dotnet-client/blob/master/Library/Rebilly/RebillySignature.cs

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1#issuecomment-236214708, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq0FpbP5os8AfqKpCzv636nPIAY_gks5qah6mgaJpZM4JYIwv .

rmcfadden commented 8 years ago

Gotcha. Thanks. The SDK is coming along nicely and it has good test code coverage. I haven't worked on it much in the last couple of weeks; however, the plan is to work on it for 1-2 hours a day for the next two weeks, at which time I should 90+% of the entities mapped.

How's your team going with the new rule engine?

Enjoy your weekend and I'll talk to you soon,

Ryan

On Fri, Jul 29, 2016 at 8:39 AM, Adam Altman notifications@github.com wrote:

Thanks, here is a reference from the older implementation. https://github.com/Rebilly/rebilly-dotnet-client/blob/master/Library/Rebilly/RebillySignature.cs

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1#issuecomment-236214708, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq0FpbP5os8AfqKpCzv636nPIAY_gks5qah6mgaJpZM4JYIwv .

adamaltman commented 8 years ago

Pretty good. We hit one snag related to the event and rule tracking. However, the control/configuration api is nearly complete.

rmcfadden commented 8 years ago

I can relate to how difficult it is to make major architectural changes after the system is live! Great to hear you guys are making good progress.

Talk to you soon,

Ryan

On Fri, Jul 29, 2016 at 8:53 AM, Adam Altman notifications@github.com wrote:

Pretty good. We hit one snag related to the event and rule tracking. However, the control/configuration api is nearly complete.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1#issuecomment-236218493, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq3ij981iYL0xP01L0Rgk-_LpLUPRks5qaiIJgaJpZM4JYIwv .

rmcfadden commented 8 years ago

OK. I have finished the Signature class and I need to integrate it into the client now.

Two quick questions:

1) How should I fit this into my client class. Should I provide a second constructor and use the signature auth for all requests, or should I just use for the create token calls? 2) Can you point me in the direction of some usage examples for the php client? I want to keep the libraries consistent.

This doco. mentions the format and that it is only used for creating client side tokens:

https://my.rebilly.com/api/documentation/#paymentToken-Create

and here's how it fits into the js client side library:

https://my.rebilly.com/api/jsdoc/#usage-Token-Creation

Ryan

On Fri, Jul 29, 2016 at 8:57 AM, Ryan McFadden ryanpmcfadden@gmail.com wrote:

I can relate to how difficult it is to make major architectural changes after the system is live! Great to hear you guys are making good progress.

Talk to you soon,

Ryan

On Fri, Jul 29, 2016 at 8:53 AM, Adam Altman notifications@github.com wrote:

Pretty good. We hit one snag related to the event and rule tracking. However, the control/configuration api is nearly complete.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1#issuecomment-236218493, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq3ij981iYL0xP01L0Rgk-_LpLUPRks5qaiIJgaJpZM4JYIwv .

adamaltman commented 8 years ago

So, we have 3 API authentication methods. This is just a utility class, because the rebilly JS needs a value in the client browser, that is not a secret, that can be used for authentication (it only has permissions to POST v2/tokens or v2.1/tokens).

We structured this in the PHP SDK in a stand-alone Util directory, because I don't think it would be used by the client to connect to Rebilly, just to help create this signature which the frontend client app will need if it uses Rebilly.js.

https://github.com/Rebilly/rebilly-php/blob/master/src/Util/RebillySignature.php

rmcfadden commented 8 years ago

Got i!. I'll provide a code example on the README.md page as this will be a common task.

Ryan

On Fri, Jul 29, 2016 at 10:42 AM, Adam Altman notifications@github.com wrote:

So, we have 3 API authentication methods. This is just a helper method, because the rebilly JS needs a value in the client browser, that is not a secret, that can be used for authentication (it only has permissions to POST v2/tokens or v2.1/tokens).

We structured this in the PHP SDK in a stand-alone Util directory, because I don't think it would be used by the client to connect to Rebilly, just to help create this signature which the frontend client app will need if it uses Rebilly.js.

https://github.com/Rebilly/rebilly-php/blob/master/src/Util/RebillySignature.php

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rebilly/Rebilly-NET-SDK/issues/1#issuecomment-236245513, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8nq1z69rcI0PApTEYkcd4ldVhr_-tuks5qajt8gaJpZM4JYIwv .