search

Rebirth-of-the-Night / Rebirth-Of-The-Night

Inspired by Terraria, 7 Days to Die, and more, Rebirth of the Night is a Minecraft 1.12.2 modpack with its own progression system, lore, mechanics, and art. It's built with the idea of remembering the central themes of what made Minecraft enjoyable and expanding them in every way, increasing the overall risk and reward as you progress.
https://www.curseforge.com/minecraft/modpacks/rebirth-of-the-night
Other
108 stars 46 forks source link

[CRASH] Salt Lamps can cause crash #1093

Open iEatShadows opened 4 months ago

iEatShadows commented 4 months ago

Describe the bug

The Salt Lamps is a great way to give buffs to you, passive mobs and hostile mobs in a 9x9x9 area by using giving the lamp Potions! Not only that, it can extend the duration of the potion you put in by 5x ! Making a 1 minute potion last up to 5 minutes!

I would believe all of the vanilla potions (strength, jump boost, etc) should work fine but Rotn has non-vanilla potions like, Fuse, Explosion, etc. that could CRASH YOUR WORLD. If you were to reload the world that just crashed with the salt lamp + non-vanilla potion combo, it will crash again and you have basically locked yourself out of your world. Some non-vanilla potions do work fine if its applied to players but might not work for the passive mob lamp or hostile mob lamp and vice versa.

I have not test all of them (every crash means a fresh new world to test the next potion on EACH lamp ugh) but it would be safe to assume the incompatibility of non-vanilla potions with Salt lamps.

I dont know if its something to do with timer vs. instant potions but instant heal potions works fine with no issues. HEH

To Reproduce

  1. Cheat/craft a Salt lamp, Passive mob lamp and/or Hostile mob lamp
  2. Cheat/craft a non-vanilla potion (Fuse, Explosions etc.)
  3. Summon a Passive mob and/or Hostile
  4. Place it into the any or all the lamps (right click with potion in hand)
  5. Either you or the mob will get the effect or just CRASH the moment you place in the potion

Expected behavior

Just doesn't crash and just give buffs to mobs correlated to the lamp that is being used.

Screenshots

https://youtu.be/fNcUOCDAHdY

Modpack Version

Other

Server or singleplayer

Singleplayer

Version the world was created on:

Other

Other...

world was created and played in 3.2.1b*

Additional context

crash-2024-04-17_12.46.17-client.txt

ProvidenceDaemon commented 4 months ago

will pass this along to the salt lamps dev

democat3457 commented 4 months ago

@iEatShadows do you have the full log file?

iEatShadows commented 4 months ago

https://mclo.gs/FBk3tL7

democat3457 commented 4 months ago

@iEatShadows the log is too long for mclo.gs :sob: (its over 25000 lines) - can you get rid of the first 25000 lines (or dm it to me on discord)

iEatShadows commented 4 months ago

crash-2024-04-23_19.38.31-client.txt

CaliforniaDemise commented 4 months ago

Are you sure it's a crash that happens because of Salt Lamps? It looks like a serverside crash happening because of JEI's workaround for enchantments. It might be better to post servers crash report instead of client.

iEatShadows commented 4 months ago

crash-2024-05-09_19.50.35-client.txt

I tried to rejoin the world and i got this crash