Rebirth-of-the-Night / Rebirth-Of-The-Night

Inspired by Terraria, 7 Days to Die, and more, Rebirth of the Night is a Minecraft 1.12.2 modpack with its own progression system, lore, mechanics, and art. It's built with the idea of remembering the central themes of what made Minecraft enjoyable and expanding them in every way, increasing the overall risk and reward as you progress.
https://www.curseforge.com/minecraft/modpacks/rebirth-of-the-night
Other
109 stars 46 forks source link

[BUG] Quality does not work on mythril armor #375

Closed Creatorofpie closed 3 years ago

Creatorofpie commented 4 years ago

Describe the bug Quality does not work on mythril armor.

To Reproduce Steps to reproduce the behavior:

  1. create mythril armor.
  2. go to reforging station and attempt to reforge to a positive quality.
  3. the quality does not actually affect you.

Expected behavior The quality should be able to affect your character, I believe this is the only armor where this is an issue.

Screenshots

Info (please complete the following information):

Additional context I believe the quality did work on 2.77.4. I guarantee that it works on 2.77.1 and 2.77.2.

democat3457 commented 4 years ago

Can reproduce on dev.

Kompreya commented 4 years ago

Qualities are being removed from armor/weapons/tools next update. Only baubles and magic items will have qualities. We may add qualities back to armor in the future, but implementation will be different.

So, we can mark this "fixed" for 2.78 since you wont be able to get qualities on mythril armor. But we need to consider this bug in our future rework of armor and weapon qualities.

democat3457 commented 3 years ago

Actually caused by https://discord.com/channels/620840315498004480/664351929505415168/850944888186994708