search

Rebirth-of-the-Night / Rebirth-Of-The-Night

Inspired by Terraria, 7 Days to Die, and more, Rebirth of the Night is a Minecraft 1.12.2 modpack with its own progression system, lore, mechanics, and art. It's built with the idea of remembering the central themes of what made Minecraft enjoyable and expanding them in every way, increasing the overall risk and reward as you progress.
https://www.curseforge.com/minecraft/modpacks/rebirth-of-the-night
Other
109 stars 46 forks source link

[BUG] Armor stands cause ridiculous amounts of server-side, client-side, and ping-side? lag #879

Open FamiliarPings opened 2 years ago

FamiliarPings commented 2 years ago

Describe the bug

For the past 2 weeks, my friend has been struggling to play the game with a decent internet connection, and this only got progressively worse. It started with him being unable to even come near my base without his ping rising massively, and even losing connection to the server. We were at a loss as to what the problem was, but dealt with it.

As he created his new base, and set up a hall of armor stands, the problem only got worse, but we didn't make the connection because, well, he was building an entire base.

Finally, as he basically became unable to play at all, I started using a mod called LagGoggles, downloaded our world into singleplayer so I could use the "World" function of the mod, and scanned both our bases.

By far, the worst offenders were the armor stands at both our bases. Upon removing them, his connection improved DRASTICALLY.

Lag1 Lag2

To Reproduce

I've not done extensive testing, but my current theory is that armor stands get progressively more "laggy" the longer they exist, and this is why his connection slowly worsened. As he had 12 or so armor stands in his previous base for a short time, without seemingly having a problem, if he did, it was mild enough not to be noticed, or was assumed to be lag due to BetterAnimalsPlusPlus, which was a huge issue at the time.

To reproduce, have an armor stand wearing armor, and holding something, the effect seems to be most apparent at 6 or more armor stands.

Expected behavior

Not lagging out the game.

Screenshots

No response

Modpack Version

3.1

Server or singleplayer

Server

Version the world was created on:

3.1

Other...

No response

Additional context

No response

TheNelston commented 2 years ago

lol thats just vanilla, dog shit armor stand implementation is a feature of mojang's incredible skills

TheNelston commented 2 years ago

https://www.youtube.com/watch?v=vp26weVppX8 see example

democat3457 commented 2 years ago

you could also try using Spark to figure out specifically what is lagging from the armor stands so we can better diagnose the issue @FamiliarPings

kil0byt3 commented 2 years ago

Though this is a vanilla issue, it seems vastly more influential in ROTN than in vanilla servers. Is it possible that we're missing something? What's especially interesting to me is that this gets worse over time - something is up here.

Easy solution - remove armor stands ;)

democat3457 commented 2 years ago

that is an easy solution, but definitely not what we want as armor stands are one of the few ways to display your armor collection to the world (and to flex your hours of grinding aether minibosses)

kil0byt3 commented 2 years ago

Absolutely agree, was just being facetious :)