search

Rebirth-of-the-Night / onslaught

Onslaught is a Minecraft Mod that gives you an interface to create Invasions of violent mobs with custom abilities, loot, and spawning conditions.
5 stars 3 forks source link

Chore/code style #20

Closed SekretOne closed 3 years ago

SekretOne commented 3 years ago

Mostly normalizing code, by applying Google Style Guide. This is an automated code cleanup.

Adhering to a consistent style guide keeps a certain legibility. Keeps multiple authors from causing distracting diffs- overall making it easier to review.

Add

  1. task on clean to wipe the run directory
  2. task on pre-runCLient to copy templates in the test resources to the run dir. These test templates are not included in the jar final config.

Change

  1. Reformat all code to Google Style. Mostly spacing and reorganize importants. Non Functional.
  2. Fix some code blocks in the docs to be json and not js.

~Fix~

Validation

  1. Run clean and runClient, runServer. No issues and could start random invasions.
democat3457 commented 3 years ago

Is this good to merge, or are we awaiting any more reviews?

SekretOne commented 3 years ago

Is this good to merge, or are we awaiting any more reviews?

It should be fine.

If it's lacking anything, it's some doc guidance on how to setup people's spaces to automatically apply the formatting. All other bits are functional.

Right now it's just more of a 'personal' rule that one other person sign off / approve. I won't leave it open indefinitely and will move forward. Will definitely merge before I do further cleanups.