search

Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
118 stars 73 forks source link

Fix/pagination links need unique keys #237

Closed adxmantium closed 4 years ago

adxmantium commented 4 years ago

Describe your PR

This PR fixes the unique "key" prop warning you get when a list items have the same key value, or in this case, the root node did not have the key prop, it was on the child node, so I just moved it and that fixes the error.

Fixes: add-keys-to-pagination trello ticket

Pages/Interfaces that will change

No UI changes

Screenshots / video of changes

Before: was seeing Warning: Each child in a list should have a unique "key" prop. Check the render method of 'Pagination'. See https://fb.me/react-warning-keys for more information.

After: no longer seeing that^ error in console

Steps to test

  1. Go to /businesses
  2. Open console
  3. Scroll towards the bottom to see Warning: Each child in a list should have a unique "key" prop. Check the render method of 'Pagination'. See https://fb.me/react-warning-keys for more information.
  4. Pull this PR down and you no longer will see that ^ warning

Additional notes

netlify[bot] commented 4 years ago

Deploy request for rebuild-black-business accepted.

Accepted with commit 9387b128aee138dbbd3eceb256d91106a6ae753a

https://app.netlify.com/sites/rebuild-black-business/deploys/5ee2fae517e483000725385b

racedale commented 4 years ago

Actually this was fixed in a PR I just merged. https://github.com/Rebuild-Black-Business/RBB-Website/pull/241