search

Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
119 stars 72 forks source link

fix whitespace block issue in allies page #265

Closed Mhmdabed11 closed 4 years ago

Mhmdabed11 commented 4 years ago

Describe your PR

Fix issue in the allies page where if you did not accept the terms and conditions, there will be a whitespace block at the end of the page. This has been fixed by giving the main element in layout.js a minHeight: calc(100vh - 475px). 475 is the sum of both the height of the header(100px) and that of the footer(375px).

Pages/Interfaces that will change

All pages in the website will be affected since they are children of the main tag.

Screenshots / video of changes

Steps to test

  1. Go to allies page
  2. Make sure that you haven't accepted the terms and conditions. If you did, then open the chrome developer tools, go to application tab, and in LocaleStorage go to the website domain. In case of development, it is usually http://localhost:8000.
  3. Delete the acceptedTAC item and refresh the page. You should now see the modal with the whitespace block fixed.
netlify[bot] commented 4 years ago

Deploy request for rebuild-black-business accepted.

Accepted with commit 217ccfe938785b6bc0aee92828d75ee0694df897

https://app.netlify.com/sites/rebuild-black-business/deploys/5ef23e42a7ccdb00073ea06f