search

Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
118 stars 73 forks source link

Create Button component and variations #30

Closed magnificode closed 4 years ago

magnificode commented 4 years ago

Buttons

Figma: https://www.figma.com/file/Lo1ZcBOO9t4QRbX2I0PwBQ/RBB?node-id=2%3A102

Buttons should extend existing Chakra UI components to achieve the style outlined in the figma document for each state and variation.

andria-dev commented 4 years ago

Working on it 👍

andria-dev commented 4 years ago

Done! https://github.com/Rebuild-Black-Business/RBB-Website/pull/34

andria-dev commented 4 years ago

I now realize that there's another PR that was put out for this (didn't see the Trello and claimed here, sorry). However, I think the PR I put up is a bit more configurable and uses the <Button> component from ChakraUI internally instead of just <PseudoBox> which has less functionality built into it (<Button> uses <PseudoBox> internally).

magnificode commented 4 years ago

@ChrisBrownie55 I am so so sorry, I hadn't had a chance to assign this to the person who had the ticket in progress as they had not been invited to the GitHub org yet (jumped into meetings directly after I created it).

We have in progress work happening via this PR https://github.com/Rebuild-Black-Business/RBB-Website/pull/23 - is there any chance you can work with them to see what we can do about leveraging any of the work you've done here?

This is 100% on me for not finishing this ticket out completely before creating it, so sorry for the confusion.

magnificode commented 4 years ago

I now realize that there's another PR that was put out for this (didn't see the Trello and claimed here, sorry). However, I think the PR I put up is a bit more configurable and uses the <Button> component from ChakraUI internally instead of just <PseudoBox> which has less functionality built into it (<Button> uses <PseudoBox> internally).

I'd love for you to collaborate with the folks working on that ticket! If leveraging <Button> over <PseudoBox> is more flexible then we definitely want to consider it. Andy has been super receptive to feedback!

andria-dev commented 4 years ago

Will do, thank you, sorry about the confusion.

magnificode commented 4 years ago

@ChrisBrownie55 no need to apologize at all. On me for trying to juggle too many things at once :)