Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
119 stars 72 forks source link

Feature/update business submit fields #307

Closed magnificode closed 4 years ago

magnificode commented 4 years ago

Describe your PR

Currently a work in progress to add new form fields for businesses based on design. Will update as I finish this up.

Related to #306

Pages/Interfaces that will change

/businesses (specifically the register a business modal)

Screenshots / video of changes

Screen Shot 2020-07-24 at 12 51 21 PM

Steps to test

  1. Navigate to the /businesses page
  2. Click "Register a business" to see the register form pop up in a modal.
  3. Ensure that form does not submit unless all required fields are filled in
  4. Ensure fields associated with conditional logic are handled properly. For example, we want to make sure that fields associated with "physical address" are not submitted for an "online only" business. This carries over to the donation link, and business owner field options.

Additional notes

The validation logic here is pretty strict, we will likely want to iterate on a couple things here, namely the way that validation messages are shown to the user, and actual form field data validation as well (i.e properly formatted URLs, numbers, addresses etc.)