Closed Mhmdabed11 closed 4 years ago
Deploy request for rebuild-black-business accepted.
Accepted with commit c9d6a3e75ffc2fd4c382a620e6162d5a0c3743d9
https://app.netlify.com/sites/rebuild-black-business/deploys/5f2fb35c5496c20008ce8d6b
Hey @Mhmdabed11 - thanks again for this work. Couple small things and then I think we should be good to get this merged. Apologies for the delay in reviewing here, been a bit of a busy couple of weeks.
Any chance we could add hyphens: auto
to the headings here? That way if a longer title shows up in a more narrow card, the content will break onto a new line? You may need to add this as an inline style
, as I'm not sure that Chakra has an attribute for this.
I added a comment about upping the container size to 1600 as well.
Appreciate the work!!
@magnificode Thank you for your comments and no worries at all! I had to add wordBreak: break-all
instead of hyphens: auto
since the hyphens
property is not fully supported by all modern browsers.
@Mhmdabed11 good call! Any chance we can leverage both? That way modern browsers get the benefit of the hyphens, and older browsers will still see the word break?
@magnificode of course! Will do it in a few.
@Mhmdabed11 excellent work as always, thank you so much for the help!
@magnificode You are most welcome!
@all-contributors please add Mhmdabed11 for code
@racedale
I've put up a pull request to add @Mhmdabed11! :tada:
Describe your PR
Adjust businesses listing grid to show 12 listings on the page, where each row has between 1 and 4 listings.
Related to #313
Pages/Interfaces that will change
/businesses
page will be affectedScreenshots / video of changes
4 listings per row![image](https://user-images.githubusercontent.com/39762577/89207027-bed19780-d5c2-11ea-8b83-258a54c7b678.png)
3 listings per row![image](https://user-images.githubusercontent.com/39762577/89207070-dad53900-d5c2-11ea-8b43-d46a12dda3c0.png)
2 listings per row![image](https://user-images.githubusercontent.com/39762577/89207113-ec1e4580-d5c2-11ea-8d4d-99726b886921.png)
1 listing per row![image](https://user-images.githubusercontent.com/39762577/89207160-fdffe880-d5c2-11ea-9ee9-1aabf91e5c70.png)
Steps to test
/businesses
page.