search

Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
119 stars 75 forks source link

Feature/smooth scroll to ID #329

Closed shapirone closed 4 years ago

shapirone commented 4 years ago

Describe your PR

Note: This is https://github.com/Rebuild-Black-Business/RBB-Website/pull/239 after I resolved merge conflicts months later

Gatsby Links don't support scrolling to hash ids in the url natively so I implemented a quick fix that is in use on Business and Legal pages. Needed to wrap business load in a timeout for more consistent experience.

Related to https://trello.com/c/QfHWbLi8/207-navigating-to-another-page-of-search-results-should-bring-you-to-the-results-portion-of-the-page-not-the-top-of-the-page-skip-th

Pages/Interfaces that will change

Legal & Business

Screenshots / video of changes

https://www.loom.com/share/b0666dedf72d421db9046e69be0f3b48

Steps to test

  1. Go to business page and scroll down to pagination on the bottom.
  2. Click a page other than the currently active page
  3. -> Smooth scroll to results section of new page

===========

  1. Go to allies page gate
  2. Click Terms and Conditions link
  3. -> Smooth scroll to TaC