Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
119 stars 75 forks source link

[BUG] We need to choose a lockfile / package install tool #330

Closed mbifulco closed 3 years ago

mbifulco commented 4 years ago

Describe the bug I noticed we have both package-lock.json and yarn.lock files in the repo. We should pick one and stick to it. Typically I use yarn, but I'm happy to go with whatever works. Any preference?

To Reproduce Steps to reproduce the behavior:

  1. peep the repo

Expected behavior We should only have one lockfile. The resolution of this issue should remove one or the other, and add that one (the removed one) to .gitignore. This should be mirrored in /functions/ as well, where a different list of dependencies is maintained.

Actual Behavior n/a really, but as far as I know it's not ideal to have both 🤔

Screenshots image

mbifulco commented 4 years ago

Hey it turns out that there's only 1 commit associated with yarn.lock and it was from me 😂

image

Let's stick with npm - I'll put up a PR to get rid of yarn.lock and add it to .gitignore