search

Rebuild-Black-Business / RBB-Website

Website to help connect black-owned businesses with consumers and resources
https://www.rebuildblackbusiness.com/
MIT License
119 stars 75 forks source link

form submission with error handling, PR includes suggestionBox #339

Open SeHarlan opened 3 years ago

SeHarlan commented 3 years ago

Describe your PR

Related to # Fixes #283

Pages/Interfaces that will change

related to SuggestionBox: ContactCard.js about.js

related to Form submissions with error handling: AritableServices.js BusinessSignUpForm.js AllySignUpForm.js

Screenshots / video of changes

Screen Shot 2020-09-04 at 2 20 09 PM Screen Shot 2020-09-04 at 2 20 03 PM

Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom

Steps to test

  1. Netlify integration submission on submission box comes back with 200 on the POST in Development, but last time we checked was still having issues in production so that should be double checked.

I've changed the elements in the suggestion box to be wrapped in a generic form (with the proper Netlify attributes) and with a default <input type="submit> so it should behave like a normal form now. Before it was using only Chakra components like PrimaryButton and FormControl and the "form" was not behaving as expected when it came to submitting with Netlify integration.

Additional notes

I did some minor clean up and basic error handling for the other forms and Airtable service functions, right now it displays the error message to the user via the validationMessage state. Let me know if that's alright or should be changed back!

netlify[bot] commented 3 years ago

Deploy request for rebuild-black-business accepted.

Accepted with commit 4662bbc619fa4839b4305b8ec1e50632450aebbd

https://app.netlify.com/sites/rebuild-black-business/deploys/5f5681e16195e00008999141

juanri0s commented 3 years ago

@SeHarlan

SeHarlan commented 3 years ago

@juanri0s Chakra components were giving us a hard time with the Netlify so this is an with inline styling. I can make a CSS module to get the focus and hover state more inline with the Chakra defaults, but was thinking about avoiding a random CSS file when there aren't any anywhere else. totally down to do that though.

On blank submission there should be a message popping up at the top, maybe we can bold that or something to make it more apparent?

juanri0s commented 3 years ago

@SeHarlan This PR will be on hold until we figure out an issue with the new business pages feature since its causing long build times