search

RechInformatica / rech-editor-batch

Edit Batch files with Visual Studio Code
MIT License
21 stars 5 forks source link

Bug: Variable renaming is broken #28

Open ostrich opened 1 year ago

ostrich commented 1 year ago

The gif shows the issue.

Steps to reproduce:

  1. Create variables with set "foo=foo.txt" and set "bar=bar.txt" and use them elsewhere in the script.
  2. Click the variables and hit F2 to rename
  3. Enter a new name for each
  4. Neither works. The foo in set "foo=foo.txt" is not renamed but %foo% is. And neither bar nor %bar% is renamed.

Code_3fvOSrzs0O

ostrich commented 1 year ago

Hate to be a pest but hoping @gustavosimon sees this :)

gustavosimon commented 1 year ago

Hello @ostrich ! How are u? Hope you're well.

First, thanks for opening this issue. I really appreciate that the extension is used by the community.

About the issue, I'm currently working in another projects but I'll see this as soon as possible.

You may be comfortable to submit a pull request to fix this issue.

This is applied to the another feature request created too.

Thanks and have a good day!

skorpio07 commented 8 months ago

one last comment is the following will work (but not optimal) set var=foo echo var now rename var. it works in both places. but the quotes are necessary, so this is a def bug. thanks for the great work.