Recidiviz / justice-counts-components

A set of React components powering a web app for exploring centralized, standardized metrics on the performance of justice systems across the United States
GNU General Public License v3.0
1 stars 0 forks source link

Fix bad percent change for NH #140

Closed colincadams closed 3 years ago

colincadams commented 3 years ago

Description of the change

We were doing some truthy/falsy comparisons when we needed to be explicitly checking against nulls so that we properly handle changes of 0.

See NH before:

Screen Shot 2021-08-09 at 5 43 45 PM

after:

Screen Shot 2021-08-09 at 5 28 14 PM

Type of change

Related issues

@hobuobi to file issue if needed

Checklists

Development

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging: