Recidiviz / justice-counts-components

A set of React components powering a web app for exploring centralized, standardized metrics on the performance of justice systems across the United States
GNU General Public License v3.0
1 stars 0 forks source link

Percentage change shows decimals #45

Closed colincadams closed 3 years ago

colincadams commented 3 years ago

Describe the bug

Currently percentage change will show all the decimals that are included in the fixture file, instead of limiting to whole percentages

To Reproduce Steps to reproduce the behavior:

  1. Change stateCode to US_CT (keeping existing checked fixture file)
  2. Run yarn start
  3. Observe long decimals in percentages

Expected behavior

This should limit to whole percentages, @hobuobi if there is any preference on rounding vs truncating, or just keep it consistent with the logic for the line graphs.

Screenshots Screenshots revealing sensitive information must not be shared. If a screenshot is helpful in diagnosing and resolving the bug, please send this directly to a contact on the Recidiviz team.

Screen Shot 2021-02-03 at 10 17 05 AM

Desktop (please complete the following information): running locally

Additional context Add any other context about the problem here.