Card percentage fixes. - Githubissues

Recidiviz / justice-counts-components

A set of React components powering a web app for exploring centralized, standardized metrics on the performance of justice systems across the United States

GNU General Public License v3.0

1 stars 0 forks source link

Card percentage fixes. #48

Closed Wmaileq closed 3 years ago

Wmaileq commented 3 years ago

Description of the change

Rounded percents on flow diagram and key insights cards.
Added support for string percent_change and number_change fields.

Type of change

[X] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #44. Closes #45.

Checklists

Development

These boxes should be checked by the submitter prior to merging:

[X] Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

[x] This pull request has a descriptive title and information useful to a reviewer
[x] This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
[x] Potential security implications or infrastructural changes have been considered, if relevant

Wmaileq commented 3 years ago

@jessex I want to rebase this branch after #37 will be merged.