Fix minor issues in tooltip

colincadams commented 3 years ago

Description of the change

For #55 there were a few underlying issues:

The dateReported is constructed with new Date("2020-11-30") which uses no timezone offset when constructing it. Then we printed it using the local timezone which would be "2020-11-29".
We use month indices throughout (matching what appear to be javascript best practices) which means that 0 is a valid month. We were using an implicit boolean check on month instead of comparing it to null, which meant the % change part of the hint was omitted, even though it was the important part of the hint in this case.
Data: Maine had a few recent monthly admissions points, and then prior to that some annual admissions data. All of them were recorded as monthly, so the annual data slipped through the calculations and was treated as monthly causing the apparent 95+% decrease shown here (and is the reason for the comparison of more than a year back to the prior january).

While I was trouncing around to try to figure out what was happening I figured I would just take a stab at fixing the first two to get more familiar with what is happening in JS land. If this feels reasonable, great, if not feel free to abandon this PR and take a different approach.

I added a test for the (2), but didn't see an easy way to mock the timezone to test (1). If there is one let me know! I also fixed the data entry error for (3) separately.

Type of change

[X] Bug fix (non-breaking change that fixes an issue)

Related issues

Closes #55

Checklists

Development

These boxes should be checked by the submitter prior to merging:

[X] Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

[x] This pull request has a descriptive title and information useful to a reviewer
[x] This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
[x] Potential security implications or infrastructural changes have been considered, if relevant

jessex commented 3 years ago

@colincadams for testing with static times or timezones, have you looked at the timekeeper package? We use it in some of our other frontend projects via import tk from "timekeeper";

Wmaileq commented 3 years ago

I've noticed tests failing in generateHint.js and decided to unify the date format to do not use the Date js class at all, as we use only UTC dates and should not depend on timezones.

Recidiviz / justice-counts-components