Recidiviz / justice-counts-components

A set of React components powering a web app for exploring centralized, standardized metrics on the performance of justice systems across the United States
GNU General Public License v3.0
1 stars 0 forks source link

Chart adjustments (#53). #61

Closed Wmaileq closed 3 years ago

Wmaileq commented 3 years ago

Description of the change

Adjustments on:

Type of change

Related issues

Closes #53.

Checklists

Development

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

jessex commented 3 years ago

@hobuobi could you also do a quick test on this one, and respond to the comment from Vlad on #53? He needs fixture data to reproduce one of the issues you called out. I've done a quick review and I think he's solved all of the issues that are testable from my end, except for one problem I note in my review below, but I want you to sign off.

hobuobi commented 3 years ago

Almost everything looks great! The only thing is that I still see the +0% issue (for example, the Probation Population on US_ND).

Wmaileq commented 3 years ago

Finally i was able to reproduce Collin's issue. I think now it is ready to be shipped.