Added more tests to main - Githubissues

Recidiviz / justice-counts-components

A set of React components powering a web app for exploring centralized, standardized metrics on the performance of justice systems across the United States

GNU General Public License v3.0

1 stars 0 forks source link

Added more tests to main #82

Closed nasaownsky closed 3 years ago

nasaownsky commented 3 years ago

Description of the change

Added more tests to main

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes [#XXXX]

Checklists

Development

These boxes should be checked by the submitter prior to merging:

[x] Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

[x] This pull request has a descriptive title and information useful to a reviewer
[x] This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
[x] Potential security implications or infrastructural changes have been considered, if relevant

nasaownsky commented 3 years ago

For now I'm focused on #80, but I can add few more tests if I don't run into any difficulties with it.

nasaownsky commented 3 years ago

@jessex I've covered generateKeyInsightsData with tests in #83, because it has some changes there.