Recidiviz / justice-counts

Technical infrastructure for the Justice Counts initiative
GNU General Public License v3.0
2 stars 0 forks source link

[Publisher][Superagencies] Add dropdown for child agencies to Explore Data page #1310

Closed nasaownsky closed 7 months ago

nasaownsky commented 7 months ago

Description of the change

  1. Added separate ChildAgenciesDropdown component
  2. Added ChildAgenciesDropdown to explore data page

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

closes #1276

Checklists

Development

This box MUST be checked by the submitter prior to merging:

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

nasaownsky commented 7 months ago

@mxosman Maybe you know what is this lint Error: 18:1 error incorrect header header/header in CI tests?

mxosman commented 7 months ago

@mxosman Maybe you know what is this lint Error: 18:1 error incorrect header header/header in CI tests?

Ah - we probably haven't updated the year in our license header in all of our files, and the new file you added shows 2024. For now, can you see if yarn lint --fix will take care of the adjustment to pass CI? I'll file a separate task for us to update these headers

mxosman commented 7 months ago

Love the consolidation here, @nasaownsky! It looks & works great for me! One small visual thing I noticed for agencies with a few available metrics - is there a good way to have the left-side (Law Enforcements > Arrest) not be centered - but be in a flex-start-like position (aligned towards the top rather than center)?

Screenshot 2024-04-23 at 9 19 48 AM

nasaownsky commented 7 months ago

@mxosman certainly, fixes applied!

helperbot-recidiviz commented 7 months ago

@brandon-hills Playtest deployment failed. See workflow failure logs at https://github.com/Recidiviz/justice-counts/actions/runs/8819915695

helperbot-recidiviz commented 7 months ago

@brandon-hills successfully triggered a playtest deployment. Full deployment usually takes 5 minutes. Your playtest link is https://brandontest---publisher-web-b47yvyxs3q-uc.a.run.app/