[Publisher][Design Update] Agency Settings: Account Tab Modals (excluding Jurisdictions) (3/5) #1257

corypride commented 7 months ago

Description of the change

Created/updated modals in the Account Tab of the Settings page.

Created Name & email modals updated the existing Modal component in the common repo to allow for custom styling via using agencySettingsConfigs flag. Added an X close button. Added styling for email validation. Updated styling for Agency Description modal.

https://github.com/Recidiviz/justice-counts/assets/121071048/c86f96a0-c414-40e9-b661-d7ba337edcd1

Refs# 1257

Closes #1257 #1258

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label	Description
Type: Bug	non-breaking change that fixes an issue
Type: Feature	non-breaking change that adds functionality
Type: Breaking Change	fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor	change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change	adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade	upgrades a project dependency - these changes are not included in release notes

Related issues

Checklists

Development

This box MUST be checked by the submitter prior to merging:

[x] Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

[ ] Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

[ ] This pull request has a descriptive title and information useful to a reviewer
[ ] This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
[ ] Potential security implications or infrastructural changes have been considered, if relevant

mxosman commented 7 months ago

Hi @corypride! The files changed is difficult to review because there are other/older commits and changes on there. When you merge the 2/5 PR into cory/agency-settings-design-udpates-feature branch - can you pull that original branch (cory/agency-settings-design-udpates-feature - so you have the latest commit that you merged in that branch) and then rebase this one on top of it?

If you're not comfortable with rebasing, we can pick this up later this week -- but if you are, I would do a git checkout -b cory/agency-settings-modals-design-updates-copy before just to make a copy of your work on this branch incase the rebase goes sideways. The goal is to have the Files changed and Commits only show the changes you made working on this branch. Rebasing can be tricky - so go slowly and LMK if you need help! I won't be online again until Friday.

mxosman commented 6 months ago

Once this is approved & merged in, let's sync up and do all the rebasing together and the final merge into main!

Recidiviz / justice-counts