Recidiviz / justice-counts

Technical infrastructure for the Justice Counts initiative
GNU General Public License v3.0
2 stars 0 forks source link

Exclude @babel packages from dependabot auto-merge #1380

Closed mxosman closed 5 months ago

mxosman commented 5 months ago

Description of the change

Exclude @babel packages from dependabot auto-merge.

This one is tough to test because uses: dependabot/fetch-metadata@v1 will throw an error if the PR's author is not dependabot. So, I passed in a string in lieu of steps.metadata.outputs.dependency-names with a comma separated list of dependency names - just to test the if and grep logic - and it properly skipped the auto-merge steps.

Screenshot 2024-06-11 at 5 08 04 PM

It won't hurt anything if this doesn't work, so I'm open to trying it and waiting for a dependabot babel package, if folks are OK with that. I've searched high and low for a way to simulate or manually trigger a dependabot package upgrade PR, to no reasonable avail (there was a discussion of a potential way to trigger it via an endpoint, but it didn't seem worth diving into that rabbit hole for this 😄).

Update: there is a way to have it check for updates, but not target a specific package. I'm going to try this after this is merged in and hope for a babel package.

Screenshot 2024-06-11 at 5 22 58 PM

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #1377

Checklists

Development

This box MUST be checked by the submitter prior to merging:

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

mxosman commented 5 months ago

Thanks for the investigation Mahmoud! Agreed that this won't hurt anything if this doesn't work, so I say let's merge and see what happens!

Thank you so much, Michelle!

mxosman commented 5 months ago

Omg - it worked!

Screenshot 2024-06-12 at 12 19 28 PM Screenshot 2024-06-12 at 12 19 12 PM

(Guess I gotta update the set-output command soon -- I'll make a note to self)