Recidiviz / justice-counts

Technical infrastructure for the Justice Counts initiative
GNU General Public License v3.0
2 stars 0 forks source link

[Publisher][Superagencies] Add filters to Home page table #1407

Closed nasaownsky closed 3 months ago

nasaownsky commented 3 months ago

Description of the change

Added search filter to the Home page table

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

closes #1349 closes #1399

Checklists

Development

This box MUST be checked by the submitter prior to merging:

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

mxosman commented 3 months ago

Hi @nasaownsky! OK - we are good to proceed with the search input and filter instead of the dropdown (as you have here). Thank you for the huge head-start here and for the example - it was super helpful to see! Let me know whenever you feel this is ready for review.

nasaownsky commented 3 months ago

Hi @mxosman! Added both filters, so now it should be ready for review! Also found bug in ChildAgenciesDropdown and resolved it in this PR.

mxosman commented 3 months ago

Happy Friday, @nasaownsky!

There is one more small change that we'll need to make as @nichelle-hall is working on moving the /custom-name PUT endpoint to the /api route instead of the /admin. Would you mind making that update? It might also make more sense to move the methods from the AdminPanelStore to the HomeStore (sorry, I'm sure that's a bit of a pain).

nasaownsky commented 3 months ago

Happy Friday to you too, @mxosman! No worries, I'll handle that 😎

mxosman commented 3 months ago

Oh also - thank you for introducing me to TanStack table! I'm using it in another project b/c of you and enjoy it very much!!

nasaownsky commented 3 months ago

@mxosman I'm happy to hear that and glad you like it, it's really awesome!

nasaownsky commented 3 months ago

🚀