[Bug Bash][Common] Fix react/no-unstable-nested-components lint errors

[mxosman]

Description of the change

Fix react/no-unstable-nested-components (Do not define components during render...) lint errors by defining the CustomYAxisTick component outside of the main component render.

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label	Description
Type: Bug	non-breaking change that fixes an issue
Type: Feature	non-breaking change that adds functionality
Type: Breaking Change	fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor	change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change	adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade	upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #803

Checklists

Development

This box MUST be checked by the submitter prior to merging:

• [x] Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

• [ ] Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

• [ ] This pull request has a descriptive title and information useful to a reviewer
• [ ] This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
• [ ] Potential security implications or infrastructural changes have been considered, if relevant

[morden35]

Looks good Mahmoud! Mind adding a screenshot or loom video to test?

[mxosman]

For sure! So, to test the lint errors, the CI Tests / Frontend tests would have a failure in the yarn lint step - but we're all clear.

The other thing to check in the UI is that the Y axis still appears on the bar charts as they do on main (I'll also deploy this to playtesting incase you want to poke around):

Agency Dashboards (main):

Agency Dashboards (this branch):

Publisher (main):

Publisher (this branch):

[helperbot-recidiviz]

@mxosman successfully triggered a playtest deployment. Full deployment usually takes 5 minutes. Your playtest link is https://mahmoudtest---publisher-web-b47yvyxs3q-uc.a.run.app/

[mxosman]

Thank you so much as always, Michelle!!