Recidiviz / justice-counts

Technical infrastructure for the Justice Counts initiative
GNU General Public License v3.0
2 stars 0 forks source link

[Publisher][Agency Settings] Add new agency definition section for court and supervision sectors #1594

Open nasaownsky opened 10 hours ago

nasaownsky commented 10 hours ago

Description of the change

Added new agency definition section for court and supervision sectors

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

closes #1540

Checklists

Development

This box MUST be checked by the submitter prior to merging:

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

nasaownsky commented 9 hours ago

Hi @nichelle-hall! Please test this feature and tell me your thoughts about my changes!

Also, I have two questions:

  1. In figma designs there is statement:

    If the supervision sector is combined, then we can exclude this entire includes/excludes section from the Agency Settings page.

but in issue description there is another statement:

If we have the unlikely & unusual case where an agency has both Court, and Supervision sectors, then we should show the all of the relevant sections when they open the modal

Could you please explain to me if my understanding based on my implementation is right or do I need to change something? If the latter, could you maybe tell me in more details about it?

  1. There is comment in figma designs about free text box, but from endpoint structure description it is not clear where it should be written.

Thank you in advance!