Recidiviz / public-dashboard

A public-facing dashboard to help educate citizens and build accountability
GNU General Public License v3.0
5 stars 3 forks source link

move domain allowlist to Auth0 action #657

Closed macfarlandian closed 1 month ago

macfarlandian commented 1 month ago

Description of the change

We already had an action that was mostly overlapping with our deprecated hook, so this just adds the missing piece of denying access to signups that don't hit the domain mapping. (The diff is a little misleading, because the domain-mapping solution was already what was live in Auth0; all I did was add the deny call at the end and move recidiviz email domains into the mapping instead of handling them separately.) While in there I reorganized the files a bit to better reflect the Auth0 resources they represent.

All of these changes are already live in staging and the hook has been deleted. You can see evidence of this working in the Auth0 logs: expected success, expected failure

Type of change

Related issues

Closes #656

Checklists

Development

These boxes should be checked by the submitter prior to merging:

Code review

These boxes should be checked by reviewers prior to merging:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11061359288

Details


Totals Coverage Status
Change from base Build 11060853639: 78.5%
Covered Lines: 2135
Relevant Lines: 2557

💛 - Coveralls
lilidworkin commented 1 month ago

Thanks so much, @macfarlandian !