Review plugin structure

RecipeMD / recipemd-extract

command line utility to scrape recipe websites

17 stars 5 forks source link

Review plugin structure #10

Open AberDerBart opened 4 years ago

AberDerBart commented 4 years ago

Right now, the evaluation order of the plugins is not exactly specified. As some sites can be used with multiple plugins, this may cause unpredictable behavior. The plugin system should be changed to have a defined hierarchy for the plugins.

tstehr commented 4 years ago

Also consider removing some plugins that are no longer needed:

chefkoch: Broken after a website redesign (#5); chefkoch recipes are currently handled by recipe_schema (see #6)
seriouseats: Can be handled by both recipe_schema and recipe_scrapers; should test which of these produces the better result

rixx commented 1 month ago

At this point, recipe-scrapers is in very active development while this project is rather inactive, so it might make sense to just trust recipemd-extract? It can parse JSON-LD schemas, chefkoch, seriouseats and various sites using wordpress recipe maker.

rixx commented 1 month ago

FWIW, while I was debugging some other problems, I made a branch where I used a simplified, non-pluggable logic that just tries recipe-scrapers, json-ld and wordpress extraction in order. It lives in my simplify branch.

AberDerBart commented 2 weeks ago

This sounds like a reasonable approach to me, feel free to create a PR :)