search

Recol / DLSS-Updater

What if you could update all the games that are detected on your system?
GNU Affero General Public License v3.0
455 stars 8 forks source link

Hang on Uncharted Legacy of Thieves Collection #6

Closed cripto135 closed 2 months ago

cripto135 commented 2 months ago

Script seems to hang at "Checking if file is in use..." for Legacy of Thieves Collection on Steam image

Recol commented 2 months ago

Unsure on the reason in particular, likely a bug to do with the await integration but tricky to tell, if you can rerun it 1/2 times to see if the same behaviour reproduces this will be helpful (in which case it's likely to do with this game in particular which I'll investigate further if so).

Chubakabrah commented 2 months ago

Mine is also hanging, which never allows any .dlls to update. Mine is hanging on Throne and Liberty Closed Beta Test.

Edit: Left it alone and it finally updated about 30-45min later.

Untitled

Recol commented 2 months ago

Hi both @Chubakabrah @cripto135 i have performed some changes to attempt to mitigate this behaviour, if you could report back if this occurs with version 2.0.1 this would be appreciated.

Chubakabrah commented 2 months ago

@Recol Working great. 2.0.2 seems super fast as well.

Recol commented 2 months ago

@Chubakabrah Greatly appreciated thanks for the feedback :)

cripto135 commented 2 months ago

Hi both @Chubakabrah @cripto135 i have performed some changes to attempt to mitigate this behaviour, if you could report back if this occurs with version 2.0.1 this would be appreciated.

Retested on 2.0.5 and bug could not be reproduced image It did seem to have a bit of trouble but the script ran very quickly and I only noticed going back through image

There were two oddities though, the Summary as shown has some duplicate entries and the game UBoat failed image

Chubakabrah commented 2 months ago

@cripto135 I've noticed it will fail if the .dll is already the correct version. Also I'm thinking the duplicate is because he's now including the frame generation .dll as well as dlss.

Recol commented 2 months ago

@cripto135 I've noticed it will fail if the .dll is already the correct version. Also I'm thinking the duplicate is because he's now including the frame generation .dll as well as dlss.

This is correct, as it's including FG/RR DLL's it will (duplicate) the output, I'll maybe try and tidy up the output to prevent this, closing this issue for now as it's resolved.