RecompiledBirds / RimVali

The RimVali: Far From Avalon code repository.
https://discord.gg/RpCM3RU
9 stars 17 forks source link

Performance decrease at change of season on specific map types due to AvaliMod.FoodPatch:Edible #29

Closed p3nguinPinata closed 3 years ago

p3nguinPinata commented 3 years ago

Describe the bug When the weather changes on a Boreal Forest map, or a Tundra map, I get large performance decreases. (145 FPS to 17, and 900 ticks down to around 300-400. I generally stop testing by this point.). For the sake of expedience I use 4x speed, but it's present on all speeds. This is most noticeable when it heads into winter and it starts snowing, or if there's a cold snap event on the map.

To Reproduce 1) Open rimworld. 2) Start new colony. 3) Select Independent Worlds Tribe scenario. 4) Any story teller, and difficulty. 5) Generate world with any seed and size that you want. 6) Select any Boreal forest, or Tundra tile. I generally gravitate toward Mountainous. 7) Go to advanced and select starting season of winter (This is just to speed up the process, it happens even in natural season progression) 8) Any pawns 9) Click okay and Pause game (Not technically necessary but it shows the effect more clearly in a moment) 10) Open Dubs performance analyzer 11) Select Update on the left hand side > Harmony Patches 12) Un-pause and fast forward.

Give it a day (Usually less) and Edible will jump. Just keep waiting and it keeps consuming resources.

Expected behavior Honestly I just expect it to perform the way it performs on Ice sheet, Temperate, Arid Shrubland, and Desert maps where it increases a bit, then quickly falls back down near the bottom of my list. Eg; How it handles in summer, and fall.

Screenshots 2021-05-12_075109

Versions:

Additional context Mod list and order; Core Royalty Dub performance analyzer (To see it, it happens regardless of if it's there or not) RimVali

This only seems to happen on Boreal Forest and Tundra at the change of season when it head's into winter and when it comes to cold snap. I haven't yet tested all maps, but as mentioned above, I didn't experience the same slow down's on Ice Sheet, Temperate, Arid Shrubland, or Desert maps.

My first playthrough it was a Coldsnap event on a boreal forest map that I first noticed it happening. I hadn't yet gotten to winter yet. On my second playthrough after altering my list, I experienced it again upon heading into winter when it brought my game down to around 2-3 FPS from a stable 30-40.

I've worked my way through over 240 mods trying to find the incompatibility but it's present even when only core, Dubs, and RimVali are activated. While you won't see the actual "process" (If that's what Edible is) without Dubs performance you should still notice your FPS decrease tremendously. Dubs just helps to make it more clear precisely what's consuming so many ticks and performance. At least that's how it is on my end. I've attempted to reinstall all mods, and the base game to no avail.

If any further information is required please let me know, and i'd happily experiment if it's required.

RecompiledBirds commented 3 years ago

Alright, I think I've fixed this.