RecompiledBirds / RimVali

The RimVali: Far From Avalon code repository.
https://discord.gg/RpCM3RU
9 stars 17 forks source link

Incompatability with Kurin HAR edition mod #30

Closed p3nguinPinata closed 3 years ago

p3nguinPinata commented 3 years ago

Describe the bug When RimVali is enabled at the same time as the Kurin HAR edition mod, almost all Kurin who spawn (no mater the source be it friendly, or hostile) have their body textures replace with pink squares. It seems having the two mods together attempts to direct the Kurin mod to load textures that aren't present within the mod itself.

To Reproduce 1) Start a new colony. 2) Any scenario, storyteller, difficulty, world seed/generation, hex and pawn groups (Doesn't matter if Avali are present or not). 3) Open debug actions menu and select "Execute raid with faction.." 4) Select either Kurin_Faction or Kurin_Faction_hostile It doesn't matter 5) Raid points, set to 2600 (Explained below) and wait for them to spawn/arrive

Alternatively; 4a) Use spawn pawn dev tool and select a Kurin faction pawn and spam click.

Expected behavior Body textures should be present.

Screenshots Without RimVali; 2021-05-13_055632

With RimVali; 2021-05-13_055354

An Error log can be found here; https://gist.github.com/HugsLibRecordKeeper/1c045eaf861488636301d5330874285d

Versions:

Additional context The reason for 2600 points for the raid was merely for the sake of expedience in order to have a lot of Kurin generate at once. I originally discovered this via just having a caravan arrive while I was on a normal map and noticed the pink squares/lack of textures. One in maybe 4-5 will have the proper texture.

The mod list and load order are as follows;

Harmony Core Royalty HugsLib De-generalize Work Humanoid Alien Races 2.0 Kurin HAR Edition RimVali: Far From Avalon

The error persisted after removing Harmoy, Royalty, and Hugslib.

Edit the ratio.

RecompiledBirds commented 3 years ago

This has been fixed! Thanks for the heads up, this could have been an issue with a lot of HAR mods that use custom bodytypes.

Now the internal race framework rimvali uses checks that they aren't a HAR pawn.

p3nguinPinata commented 3 years ago

I feel this is an extension of the above issue, so I wanted to post this here. But please, let me know if you would rather I open a separate issue for this instead. In a nutshell, when you do an Avali start (either of the two options) and you use the devtool to spawn in either "Tribesperson" or "Colonist" you'll end up with the pink square issue. It only seems to happen with an Avali start, so I can't really test without it. I apologize for that.

The only mods being ran are;

Harmony Core Royalty [Official DLC] HugsLib JecsTools (Unofficial) Humanoid Alien Races 2.0 RimVali: Far From Avalon

Here's an error log for it; https://gist.github.com/HugsLibRecordKeeper/331d6e05403a65a93a5afc8f4e61a459

RecompiledBirds commented 3 years ago

This isss an issue I've found while running with HAR, however I'm not sure what the issue with it is. As it doesn't seem to effect the gameplay, I'm mostly leaving it for now. I'll probably come back to it in the future, but for now it's tolerable, I think

p3nguinPinata commented 3 years ago

Alrighty! I just wanted to let you know just in case you weren't aware!

RecompiledBirds commented 3 years ago

yep! thanks! ^-^