search

ReconfigureIO / goblin

convert from a Go AST to JSON
Apache License 2.0
42 stars 15 forks source link

Add go fmt target to Makefile #39

Closed lanzafame closed 7 years ago

lanzafame commented 7 years ago

I have added the fmt target as a dependency of the test target as this suits a local development workflow well (i.e. add/change code -> make test => go fmt && go test) but I am not sure if this is ideal as that would mean that the Travis CI build will also run go fmt, but I will defer the decision to the maintainers.

The fmt target affects the fixtures directory and does change the formatting of the fixture files. I am assuming by the nature of the project (AST -> JSON) that the formatting shouldn't matter but thought it worth noting.

codecov-io commented 7 years ago

Current coverage is 55.24% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files             1          1          
  Lines           581        581          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            321        321          
  Misses          225        225          
  Partials         35         35

Powered by Codecov. Last update a72e012...2f6d3ba

patrickt commented 7 years ago

I use Emacs to hit gofmt automatically, but this looks good to me! Thank you!